Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isDeleted to meta #265

Closed
gra-moore opened this issue Dec 2, 2021 · 4 comments · Fixed by #280
Closed

Add isDeleted to meta #265

gra-moore opened this issue Dec 2, 2021 · 4 comments · Fixed by #280

Comments

@gra-moore
Copy link
Collaborator

For the streaming protocol to work it is necessary for resources to indicate if they have been deleted.

Proposal is to add a isDeleted boolean to the meta structure.

This is backwards compatible and makes sense alongside the other meta properties.

The value is optional and defaults to false.

@gra-moore
Copy link
Collaborator Author

It would look something like this:

`{
"description": "Generic meta data on this resource",

"type": "object",

"required": [
"source",
"modified"
],

"properties": {
"source": {
"type": "string",
"description": "Source where data is retrieved from. URI or reverse DNS that identifies the source system."
},
"sourceId": {
"type": "string",
"description": "Unique Id (ideally UUID) for the resource in the original source system. Treat source and sourceId as an icarIdentifierType."
},
"isDeleted": {
"type": "boolean",
},
"modified": {
"$ref": "../types/icarDateTimeType.json"
},
"created": {
"$ref": "../types/icarDateTimeType.json",
"nullable": true
},
"creator": {
"type": "string",
"description": "Person or organisation who created the object"
},
"validFrom": {
"$ref": "../types/icarDateTimeType.json",
"nullable": true
},
"validTo": {
"$ref": "../types/icarDateTimeType.json",
"nullable": true
}
}
}`

@stale
Copy link

stale bot commented Mar 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-issue Identifies that an issue is stale and will be closed unless reactivated. label Mar 16, 2022
@cookeac cookeac removed the stale-issue Identifies that an issue is stale and will be closed unless reactivated. label Mar 16, 2022
@cookeac
Copy link
Collaborator

cookeac commented May 20, 2022

Resolved by #280

@cookeac cookeac linked a pull request May 20, 2022 that will close this issue
@stale
Copy link

stale bot commented Aug 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-issue Identifies that an issue is stale and will be closed unless reactivated. label Aug 30, 2022
@cookeac cookeac removed the stale-issue Identifies that an issue is stale and will be closed unless reactivated. label Aug 30, 2022
@cookeac cookeac closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants