Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Birth Period in icarInventoryClassificationType doesn't validate as per description #335

Closed
cookeac opened this issue Oct 5, 2022 · 1 comment · Fixed by #334
Closed

Comments

@cookeac
Copy link
Collaborator

cookeac commented Oct 5, 2022

The birthPeriod in icarInventoryClassificationType was intended to represent an approximate birth period for a number of animals with an ISO8601 interval (effectively a range between two dates, but there are extensions that allow year or year and month).
I had originally drafted this as an icarDateType which is just string format date. However, most validators only accept RFC-3339 dates in this context, and not intervals.

I propose to make this a string, with a pattern that reflects the description.

@cookeac
Copy link
Collaborator Author

cookeac commented Oct 5, 2022

Resolved by #334 (hopefully)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant