Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icarResourceCollection unnecessary inheritance from icarResource #62

Closed
ahokkonen opened this issue Jan 31, 2020 · 3 comments
Closed

icarResourceCollection unnecessary inheritance from icarResource #62

ahokkonen opened this issue Jan 31, 2020 · 3 comments

Comments

@ahokkonen
Copy link
Contributor

Is there any real need to have resource collection (icarResourceCollection.jso) be inherited from icarResource base structure? As I understand MetaData is single resource related entity, but not collection of recources.
@cookeac
Copy link
Collaborator

cookeac commented Feb 12, 2020

I agree, I can think of cases where a collection might be a resource itself with MetaData and ID, but these are special cases. There is no reason why the icarResourceCollection should inherit from icarResource.

@cookeac
Copy link
Collaborator

cookeac commented Feb 12, 2020

Addressed in PR #67; discovered there were a few things to merge so leaving this open until merged in case we modify the PR.

@cookeac
Copy link
Collaborator

cookeac commented Feb 13, 2020

PR #67 is now merged.

@cookeac cookeac closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahokkonen @cookeac