Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomSheetNavigator does not properly handle click outside to dismiss #32

Closed
Tolriq opened this issue Dec 11, 2021 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@Tolriq
Copy link

Tolriq commented Dec 11, 2021

When clicking outside the bottomsheet to close it, the navigator is not involved currently, meaning that it won't replace the stack leading to display issue on the next show + keeping the composables / viewmodel in memory.

Solution is to use the confirmStateChange parameter of the sheet state and when the target is Hidden, manually call the navigator hide and return false to not let the default handling happen.

@adrielcafe adrielcafe added the bug Something isn't working label Dec 16, 2021
@adrielcafe
Copy link
Owner

Thanks again! Will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants