Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field names in Data.Graph #648

Closed
barrettj12 opened this issue Nov 25, 2021 · 1 comment · Fixed by #655
Closed

Field names in Data.Graph #648

barrettj12 opened this issue Nov 25, 2021 · 1 comment · Fixed by #655

Comments

@barrettj12
Copy link
Contributor

In Data.Graph.Base, directed graphs are defined

record Graph ℓv ℓe : Type (ℓ-suc (ℓ-max ℓv ℓe)) where
  field
    Obj : Type ℓv
    Hom : Obj → Obj → Type ℓe

Surely these should be called Vertex/Node and Edge instead?
@mortberg
Copy link
Collaborator

Good catch! I prefer Node/Edge

@barrettj12 barrettj12 mentioned this issue Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Obj -> Node and Hom -> Edge in Cubical.Data.Graph barrettj12/cubical
2 participants
@mortberg @barrettj12