Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Tests for Sample 04.3 #198

Open
1 of 5 tasks
ouphi opened this issue Mar 30, 2022 · 4 comments
Open
1 of 5 tasks

Automated Tests for Sample 04.3 #198

ouphi opened this issue Mar 30, 2022 · 4 comments
Labels
on hold Issue is planned for later and should not be worked on story

Comments

@ouphi
Copy link

ouphi commented Mar 30, 2022

Feature #194
upstream: eclipse-edc#1045
After #252

Description

Automated integration tests that run in CI should be added for samples to prevent the samples breaking due to changes in the EDC.
The scope of this story is to add automated integration tests for sample 04.3.

Sample 04.3 is based on a docker-compose + commands specified in the readme.
Having tests running the docker-compose + the commands to make sure that the sample is not broken would help avoiding breaking it.

The existing client-side integration test can be used: FileTransferAsClientIntegrationTest

Note: it was decided that EDC integration tests should not rely on samples. However, it is desirable to have additional tests to make sure that the samples don't get broken.

Acceptance criteria

  • Automated tests run in CI.

Tasks

  • Create related an issue in upstream repository
  • Verify sample matches current architecture of EDC
  • Add integration test for sample
  • Integrate integration test into CI
@zeier
Copy link

zeier commented Apr 19, 2022

Decision required whether we have tests for samples in the first place. Issue currently is that samples break all the time.

@zeier
Copy link

zeier commented Apr 26, 2022

Backlog refinement: Samples 4.0 to 4.3 should have automated tests to prevent that these samples get broken.

@zeier zeier changed the title Add test for sample 04.3 Automated Test for Sample 04.3 Apr 29, 2022
@zeier zeier changed the title Automated Test for Sample 04.3 Automated Tests for Sample 04.3 Apr 29, 2022
@pkirch pkirch self-assigned this May 2, 2022
@zeier zeier removed the team review label May 6, 2022
@zeier zeier moved this to Ready in Agera EDC May 11, 2022
@algattik algattik added the blocked This item is blocked over the outcomes of another issue/discussion. label May 12, 2022
@zeier zeier removed the blocked This item is blocked over the outcomes of another issue/discussion. label Jun 1, 2022
@zeier zeier moved this from Ready to Planned in Agera EDC Jun 29, 2022
@pkirch pkirch moved this from Planned to In Progress in Agera EDC Jul 11, 2022
@pkirch pkirch moved this from In Progress to Planned in Agera EDC Jul 12, 2022
@zeier zeier removed the status in Agera EDC Jul 13, 2022
@zeier zeier moved this to Ready in Agera EDC Jul 13, 2022
@zeier zeier added the on hold Issue is planned for later and should not be worked on label Jul 13, 2022
@zeier
Copy link

zeier commented Jul 13, 2022

Put on hold, as it is projected to be too much scope for the team until end of August.
#36 and #157 have higher priority.
This item can be taken up again if there is capacity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Issue is planned for later and should not be worked on story
Projects
Status: Ready
Development

No branches or pull requests

4 participants