Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is grid columns prop named rows? #1971

Closed
tinymins opened this issue Sep 13, 2017 · 1 comment
Closed

Why is grid columns prop named rows? #1971

tinymins opened this issue Sep 13, 2017 · 1 comment
Labels
component/grid

Comments

@tinymins
Copy link 

<grid :rows="rows"></grid>

Here's the code. Actually the 'rows' property turn out to be the columns count of this grid. Did you guys have row and column mixed up?
@airyland
Copy link
Owner

Yes, that's a naming mistake. And prop:rows is deprecated after next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/grid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@airyland @tinymins