Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local deployment of routers using config throws exception #350

Closed
rogeralsing opened this issue Aug 29, 2014 · 4 comments
Closed

Local deployment of routers using config throws exception #350

rogeralsing opened this issue Aug 29, 2014 · 4 comments

Comments

@rogeralsing
Copy link
Contributor

Found a bug in the local deployer when deploying local routers.
Changes in Akka.Configuration have improved our fallback support, which caused locally deployed routers to read a value from the fallback that was previously not found.
the "remote" setting for deployment returns empty string now, previously null.
We need to check for empty string also when determining if the deploy is local

@Aaronontheweb
Copy link
Member

@rogeralsing this is part of the most recent changes, right - nothing that's made it into the NuGet package yet?

@rogeralsing
Copy link
Contributor Author

I think it is from the multi level hocon fallback. and that is already in Nuget, right?

It has nothing to do with remoting or InjectTopLevelFallback or such.
There is a "remote" key for deployment, which contains the path to deploy to.
previously that key returned null, now it returns emptystring which is not tested for.

@Aaronontheweb
Copy link
Member

actually nah, we're ok - most recent NuGet package is two weeks old. Your config changes came in less than a week ago.

We should definitely fix this before the next release.

@rogeralsing
Copy link
Contributor Author

Closed by #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants