Inbox do not handle timeouts correctly

[HCanber]

For me Inbox_have_maximum_queue_size fails sometimes.

The test ends with this part that fails:

//The inbox should be empty now, so receiving should result in a timeout                
Assert.Throws<TimeoutException>(() =>
{
    var received=_inbox.Receive(TimeSpan.FromSeconds(1));
    Log.Error("Received "+received);
});

Inbox times out, but depending on where and how it does it different things happens.

Receive is implemented like this:

var task=Receiver.Ask(new Get(DateTime.Now + timeout), Timeout.InfiniteTimeSpan);
if (task.Wait(timeout))
{
    return task.Result;
}
else
{
    var fmt = string.Format("Inbox {0} didn't received a response message in specified timeout {1}", 
        Receiver.Path, timeout);
    throw new TimeoutException(fmt);
}

If task.Wait times out the code returns false, and the expected exception is thrown and the test passes.
If the inbox times out internally (when handling the Kick message) the Receiver gets a Status.Failure(new TimeoutException("Deadline passed")) and the test failes.

Which is correct? To send a Failure message to receiver or raise a TimeoutException?

[annymsMthd]

Changes were merged in 6c77299 to handle this. Please review and ensure this was the correct way to resolve this issue

[HCanber]

Looks ok to me.

[Horusiath]

Closed by #857