Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider stabilization #5

Closed
1 task
Ekleog opened this issue Aug 9, 2018 · 4 comments · Fixed by #10
Closed
1 task

Consider stabilization #5

Ekleog opened this issue Aug 9, 2018 · 4 comments · Fixed by #10

Comments

@Ekleog
Copy link

Ekleog commented Aug 9, 2018

This crate has seen 1.2M download, yet its (stable, I'm assuming the nightly feature counts as unstable) API appears to have not seen a single change in two years, nor has any issue been raised with it that could impact stability of its API.

Just thinking maybe this would make scoped-tls a good candidate for stabilization? :)


Concerns:

  • :vis is not stable, and required to merge the feature nightly into the default behaviour
@alexcrichton
Copy link
Owner

I think this'd be a great candidate for stabilization! I think that the nightly feature also is likely no longer needed, I believe the relevant feature was stabilized in rustc.

If you'd like to help out I'd love to have a PR to bump the versions and remove the nightly feature, and after that I think it's safe to release 1.0!

@Ekleog
Copy link
Author

Ekleog commented Aug 9, 2018

Hmm, it looks like :vis is still feature-gated on play.rust-lang (example).

As it looks like it is going to be stabilized in the next release, would you rather wait for the next release, or would it make sense to switch to 1.0 with the nightly feature not included in stability guarantees (afaik the only way to handle partially-stable APIs à la rustc) and when :vis is merged, merge the two features? (as it would be a strict extension of the syntax, I don't think it'd break backwards-compat).

The safest option is probably to wait a bit more, though, but it's your pick :)

@alexcrichton
Copy link
Owner

Ah oops thanks for checking! In that case yeah let's wait for the next release, and then 1.0 sounds good to me!

@Xanewok
Copy link
Contributor

Xanewok commented Feb 24, 2019

Heads up - :vis is stable since 1.30 and I submitted a PR that removes the feature flag altogether: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants