Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto parameters and dependence on config params #3257

Closed
algonautshant opened this issue Nov 30, 2021 · 1 comment
Closed

crypto parameters and dependence on config params #3257

algonautshant opened this issue Nov 30, 2021 · 1 comment

Comments

@algonautshant
Copy link
Contributor

In an effort to separate cryto package from config, the dependance of crypto on the consensus parameters is broken.
However, some dependance remains for testing purposes.
The task here is to move any tests that depend on the consensus params outside of the crypto package.
e.g. crypto/compactcert/builder_test.go

Moreover, hard-coded values in the crypto tests need to be replaced by the appropriate variables, whenever applicable.
e.g. TestConsensusCompactCertParams (see comments in #3181)

@id-ms
Copy link
Contributor

id-ms commented May 22, 2022

once #3991 will get merged into the feature branch. crypto package will no longer reference the config package.

@id-ms id-ms closed this as completed May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants