Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy-load langspec.json to save space on the 32KB JSON file #316

Closed
jdtzmn opened this issue Mar 22, 2021 · 1 comment
Closed

Lazy-load langspec.json to save space on the 32KB JSON file #316

jdtzmn opened this issue Mar 22, 2021 · 1 comment
Labels
Enhancement Team Lamprey

Comments

@jdtzmn
Copy link
Contributor

jdtzmn commented Mar 22, 2021

Importing langspec.json in its entirety immediately adds 32kb to the webpack bundle. Ideally, we should dynamically import the JSON file only when it is needed. Refer to the webpack docs for more details and possible implementation examples.
@algoanne algoanne added Team Lamprey and removed FDE labels Dec 28, 2022
@Eric-Warehime
Copy link
Contributor

langspec.json was removed entirely in #632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Team Lamprey
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdtzmn @Eric-Warehime @algoanne