Skip to content

Commit 998a2ac

Browse files
Merge pull request #15 from Eric-Warehime/golang-1.17-upgrade
Golang 1.17 upgrade
2 parents 69c487e + 9f06576 commit 998a2ac

File tree

5 files changed

+30
-10
lines changed

5 files changed

+30
-10
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ msgp/cover.out
99
*~
1010
*.coverprofile
1111
.idea/
12+
cover.out

Makefile

+3-8
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
# Installation can still be performed with a
55
# normal `go install`.
66

7-
# generated integration test files
8-
GGEN = ./_generated/generated.go ./_generated/generated_test.go
97
# generated unit test files
108
MGEN = ./msgp/defgen_test.go
119

@@ -20,28 +18,25 @@ $(BIN): */*.go
2018

2119
install: $(BIN)
2220

23-
$(GGEN): ./_generated/def.go
24-
go generate ./_generated
25-
2621
$(MGEN): ./msgp/defs_test.go
2722
go generate ./msgp
2823

2924
test: all
30-
go test ./... ./_generated
25+
go test -covermode=atomic -coverprofile=cover.out ./...
3126

3227
bench: all
3328
go test -bench ./...
3429

3530
clean:
36-
$(RM) $(GGEN) $(MGEN)
31+
$(RM) $(MGEN)
3732

3833
wipe: clean
3934
$(RM) $(BIN)
4035

4136
get-deps:
4237
go get -d -t ./...
4338

44-
all: install $(GGEN) $(MGEN)
39+
all: install $(MGEN)
4540

4641
# travis CI enters here
4742
travis:

go.mod

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
11
module github.com/algorand/msgp
22

3-
go 1.16
3+
go 1.17
44

55
require (
66
github.com/ttacon/chalk v0.0.0-20160626202418-22c06c80ed31
77
golang.org/x/tools v0.0.0-20200423205358-59e73619c742
88
)
9+
10+
require (
11+
golang.org/x/mod v0.2.0 // indirect
12+
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 // indirect
13+
)

printer/print.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,6 @@ func writeImportHeader(b *bytes.Buffer, imports ...string) {
145145
}
146146

147147
func writeBuildHeader(b *bytes.Buffer, buildHeaders []string) {
148-
headers := fmt.Sprintf("// +build %s\n\n", strings.Join(buildHeaders, " "))
148+
headers := fmt.Sprintf("//go:build %s\n// +build %s\n\n", strings.Join(buildHeaders, " "), strings.Join(buildHeaders, " "))
149149
b.WriteString(headers)
150150
}

printer/print_test.go

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
package printer
2+
3+
import (
4+
"bytes"
5+
"testing"
6+
)
7+
8+
func TestWriteBuildHeader(t *testing.T) {
9+
testBuf := bytes.NewBuffer(make([]byte, 0, 4096))
10+
buildHeaders := []string{"foobar"}
11+
expectedBuf := bytes.NewBuffer(make([]byte, 0, 4096))
12+
expectedBuf.WriteString("//go:build foobar\n// +build foobar\n\n")
13+
14+
writeBuildHeader(testBuf, buildHeaders)
15+
16+
if testBuf.String() != expectedBuf.String() {
17+
t.Errorf("testBuf:\n%s not equal to expectedBuf:\n%s", testBuf, expectedBuf)
18+
}
19+
}

0 commit comments

Comments
 (0)