regenerate jumborow.wasm when EOSIO_COMPILE_TEST_CONTRACTS enabled
#1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Nov 13, 2024
| add_custom_command(OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/jumborow.wasm" | ||
| COMMAND "${CDT_ROOT}/bin/eosio-wast2wasm" "${CMAKE_CURRENT_SOURCE_DIR}/jumborow.wast" -o "${CMAKE_CURRENT_BINARY_DIR}/jumborow.wasm" | ||
| DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/jumborow.wast") | ||
| add_custom_target(gen_jumborow_wasm ALL DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/jumborow.wasm") |
There was a problem hiding this comment.
Using ALL is an anti-pattern imo. But since we're building this with ExternalProject, and then
spring/unittests/CMakeLists.txt
Line 43 in f871bf2
on top of that, doesn't really seem to be too offensive to stuff this in
ALL
heifner
approved these changes
Nov 13, 2024
linh2931
approved these changes
Nov 13, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
EOSIO_COMPILE_TEST_CONTRACTSis set, regenerate the wasm from the wast using cdt tooling.