fix(g-svg): autoDraw should be true and immutable, close #191

Author: dengfuping

packages/g-svg/__tests__/bugs/issue-191-spec.js

@@ -0,0 +1,42 @@
+import { expect } from 'chai';
+import getCanvas from '../get-canvas';
+
+describe('#191', () => {
+  let canvas;
+  let circle;
+
+  before(() => {
+    canvas = getCanvas('svg-circle');
+    circle = canvas.addShape('circle', {
+      attrs: {
+        x: 20,
+        y: 20,
+        r: 20,
+        fill: 'red',
+      },
+    });
+  });
+
+  it.only('autoDraw should be true and immutable', () => {
+    expect(canvas.get('autoDraw')).eqls(true);
+    canvas.set('autoDraw', false);
+    expect(canvas.get('autoDraw')).eqls(true);
+  });
+
+  it.only('avoid redundant rendering when animating and repeat is true', (done) => {
+    circle.animate(
+      {
+        r: 40,
+      },
+      {
+        duration: 200,
+        repeat: true,
+      }
+    );
+    setTimeout(() => {
+      const count = document.getElementsByTagName('circle').length;
+      expect(count).eqls(1);
+      done();
+    }, 1000);
+  });
+});

packages/g-svg/src/canvas.ts

@@ -10,7 +10,21 @@ import Defs from './defs';
 
 class Canvas extends AbstractCanvas {
   constructor(cfg) {
-    super(cfg);
+    super({
+      ...cfg,
+      autoDraw: true,
+    });
+  }
+
+  // 覆盖基类中的 set 方法
+  set(name, value) {
+    // autoDraw 不可修改，始终为 true
+    // TODO: 应该在控制台给出 Warning 提示，引导用户避免这种用法。需要在 @antv/util 中提供通用的 warning 方法，便于在其他 antv 项目中使用
+    if (name === 'autoDraw') {
+      this.cfg[name] = true;
+    } else {
+      super.set(name, value);
+    }
   }
 
   /**