fix(api_fastapi): rename methods argument to method

Author: Lee-W

airflow/api_fastapi/core_api/security.py

@@ -16,7 +16,6 @@
 # under the License.
 from __future__ import annotations
 
-from collections.abc import Container
 from functools import cache
 from typing import TYPE_CHECKING, Annotated, Callable
 
@@ -111,13 +110,11 @@ def to_orm(self, select: Select) -> Select:
         return select.where(DagModel.dag_id.in_(self.value))
 
 
-def permitted_dag_filter_factory(
-    methods: Container[ResourceMethod],
-) -> Callable[[Request, BaseUser], PermittedDagFilter]:
+def permitted_dag_filter_factory(method: ResourceMethod) -> Callable[[Request, BaseUser], PermittedDagFilter]:
     """
     Create a callable for Depends in FastAPI that returns a filter of the permitted dags for the user.
 
-    :param methods: whether filter readable or writable.
+    :param method: whether filter readable or writable.
     :return: The callable that can be used as Depends in FastAPI.
     """
 
@@ -126,14 +123,14 @@ def depends_permitted_dags_filter(
         user: GetUserDep,
     ) -> PermittedDagFilter:
         auth_manager: BaseAuthManager = request.app.state.auth_manager
-        permitted_dags: set[str] = auth_manager.get_permitted_dag_ids(user=user, methods=methods)
+        permitted_dags: set[str] = auth_manager.get_permitted_dag_ids(user=user, method=method)
         return PermittedDagFilter(permitted_dags)
 
     return depends_permitted_dags_filter
 
 
-EditableDagsFilterDep = Annotated[PermittedDagFilter, Depends(permitted_dag_filter_factory(["PUT"]))]
-ReadableDagsFilterDep = Annotated[PermittedDagFilter, Depends(permitted_dag_filter_factory(["GET"]))]
+EditableDagsFilterDep = Annotated[PermittedDagFilter, Depends(permitted_dag_filter_factory("PUT"))]
+ReadableDagsFilterDep = Annotated[PermittedDagFilter, Depends(permitted_dag_filter_factory("GET"))]
 
 
 def requires_access_pool(method: ResourceMethod) -> Callable[[Request, BaseUser], None]:

tests/api_fastapi/core_api/routes/public/test_dags.py

@@ -244,7 +244,7 @@ def test_get_dags(self, test_client, query_params, expected_total_entries, expec
     def test_get_dags_should_call_permitted_dag_ids(self, mock_get_permitted_dag_ids, test_client):
         mock_get_permitted_dag_ids.return_value = {DAG1_ID, DAG2_ID}
         response = test_client.get("/public/dags")
-        mock_get_permitted_dag_ids.assert_called_once_with(user=mock.ANY, methods=["GET"])
+        mock_get_permitted_dag_ids.assert_called_once_with(user=mock.ANY, method="GET")
         assert response.status_code == 200
         body = response.json()
 
@@ -355,7 +355,7 @@ def test_patch_dags_should_call_permitted_dag_ids(self, mock_get_permitted_dag_i
         response = test_client.patch(
             "/public/dags", json={"is_paused": False}, params={"only_active": False, "dag_id_pattern": "~"}
         )
-        mock_get_permitted_dag_ids.assert_called_once_with(user=mock.ANY, methods=["PUT"])
+        mock_get_permitted_dag_ids.assert_called_once_with(user=mock.ANY, method="PUT")
         assert response.status_code == 200
         body = response.json()