-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker "read-only" repo with changes from Airflow pushed to it. #11740
Comments
cc: @landier |
+1 This will allow us to create a separate README.md file for this image. Currently, In DockerHub README.md from our apache/airflow repository is available, which is not very useful for a Docker image user. Dockerhub apache/airflow: https://hub.docker.com/r/apache/airflow I would prefer we had a separate README.md file for the image. The Keycloaak approach is similar |
Hey @landier - Please take a look at https://github.com/potiuk/airflow-docker where I implemented it. You just need to:
I think that should do the job nicely :). Please let me know what you think. I restarted relevant discussion in our monorepo vs. multiple repo thread - where I described how it works: https://lists.apache.org/thread.html/ra4eba1d28ece8b8276067dc2a947f8192a89a43cdb15c1699b8dba7d%40%3Cdev.airflow.apache.org%3E |
Thanks, I'll look at it! |
OK so I did some test and it looks perfect: easy to customize the build, low footprint... Thanks again. |
I will move it to "airflow-docker" repo shortly :) |
@potiuk this could be moved out of 2.0rc1 milestone I believe. |
This work depends on releasing Airflow 2.0 and #12990 merged. |
Just FYI - once we relase 2.0, this will be part of Airflow 2.0 "cleanup work" |
Not needed after #22492. With the new Biuildkit features we can have the Dockerfile standalone, which removes the need of having a separate repository for Dockerfile as it is just a standalone file |
Following a discussion in #8872 I believe it's a good idea to have a separate 'read-only" repository, where only a Dockerfile and corresponding scripts and documentation would be pushed from Airflow automatically.
We still want to keep the Dockerfile in Airlfow's mono-repo, but having a separate Dockerfile that can be conveniently used by the developers woudl be a big plus for anyone who would like to - potentially contribute back to Airflow and use only the "Docker" part of it - Either via subrepo or submodule.
Depends on :
The text was updated successfully, but these errors were encountered: