Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker "read-only" repo with changes from Airflow pushed to it. #11740

Closed
potiuk opened this issue Oct 22, 2020 · 10 comments
Closed

Docker "read-only" repo with changes from Airflow pushed to it. #11740

potiuk opened this issue Oct 22, 2020 · 10 comments
Assignees
Labels
area:production-image Production image improvements and fixes

Comments

@potiuk
Copy link
Member

potiuk commented Oct 22, 2020

Following a discussion in #8872 I believe it's a good idea to have a separate 'read-only" repository, where only a Dockerfile and corresponding scripts and documentation would be pushed from Airflow automatically.

We still want to keep the Dockerfile in Airlfow's mono-repo, but having a separate Dockerfile that can be conveniently used by the developers woudl be a big plus for anyone who would like to - potentially contribute back to Airflow and use only the "Docker" part of it - Either via subrepo or submodule.

Depends on :

@potiuk potiuk self-assigned this Oct 22, 2020
@potiuk potiuk added this to the Airflow 2.0.0 milestone Oct 22, 2020
@potiuk
Copy link
Member Author

potiuk commented Oct 22, 2020

cc: @landier

@mik-laj
Copy link
Member

mik-laj commented Oct 22, 2020

+1 This will allow us to create a separate README.md file for this image. Currently, In DockerHub README.md from our apache/airflow repository is available, which is not very useful for a Docker image user.

Dockerhub apache/airflow: https://hub.docker.com/r/apache/airflow

I would prefer we had a separate README.md file for the image. The Keycloaak approach is similar
Dockerhub: https://hub.docker.com/r/jboss/keycloak/
README.md for Docker image on Github: https://github.com/keycloak/keycloak-containers/blob/master/README.md
README.md for Keycloak project on Github: https://github.com/keycloak/keycloak/blob/master/README.md

@potiuk
Copy link
Member Author

potiuk commented Oct 25, 2020

Hey @landier - Please take a look at https://github.com/potiuk/airflow-docker where I implemented it.

You just need to:

  1. clone the repo
  2. check out the "master" branch
  3. run docker build pointing out to the version of Airflow you want to install (see the README)

I think that should do the job nicely :). Please let me know what you think.

I restarted relevant discussion in our monorepo vs. multiple repo thread - where I described how it works: https://lists.apache.org/thread.html/ra4eba1d28ece8b8276067dc2a947f8192a89a43cdb15c1699b8dba7d%40%3Cdev.airflow.apache.org%3E

@landier
Copy link

landier commented Oct 26, 2020

Thanks, I'll look at it!

@landier
Copy link

landier commented Oct 26, 2020

OK so I did some test and it looks perfect: easy to customize the build, low footprint...
I really appreciate this and I'm sure others would/will.

Thanks again.

@potiuk
Copy link
Member Author

potiuk commented Oct 29, 2020

I will move it to "airflow-docker" repo shortly :)

@potiuk potiuk added the area:production-image Production image improvements and fixes label Nov 12, 2020
@ryw
Copy link
Member

ryw commented Dec 1, 2020

@potiuk this could be moved out of 2.0rc1 milestone I believe.

@potiuk
Copy link
Member Author

potiuk commented Dec 11, 2020

This work depends on releasing Airflow 2.0 and #12990 merged.

@potiuk
Copy link
Member Author

potiuk commented Dec 11, 2020

Just FYI - once we relase 2.0, this will be part of Airflow 2.0 "cleanup work"

@potiuk
Copy link
Member Author

potiuk commented Mar 26, 2022

Not needed after #22492. With the new Biuildkit features we can have the Dockerfile standalone, which removes the need of having a separate repository for Dockerfile as it is just a standalone file

@potiuk potiuk closed this as completed Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:production-image Production image improvements and fixes
Projects
None yet
Development

No branches or pull requests

4 participants