You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yeah, I agree this isn't ideal. At the time, I thought this was probably a reasonable way to translate to the arrow fixed size binary data type, but in reality, we should have tried a way to limit to only Base.CodeUnits like we do now for the list data type. The problem is that we now unequivocally treat Base.CodeUnits as list, so there's not a straightforward way to say, "hey, I have a vector of fixed size binary data and want the fixed size binary arrrow data type". We could create a wrapper like Arrow.FixedSizeBinary that people would have to use explicitly, but that's a bit annoying. Let me think on this one for just a bit.
In any case, we would probably want to modify the FixedSizeListKind in ArrowTypes to also have a 3rd type parameter to track whether the fixed size should be binary or not (since we don't want to unequivocally treat UInt8 eltype as binary, which is the core issue here).
similar to #411 but corresponds to
fixedsizelist.jl
:The text was updated successfully, but these errors were encountered: