From 28d4de1692debd8cf10e48a67a0982febaeed083 Mon Sep 17 00:00:00 2001 From: reshke Date: Fri, 16 Aug 2024 14:51:29 +0500 Subject: [PATCH 1/3] Rephrase comment for deferred IVM case Have been studying AQUMV feature internals today. Noticed the typo in comment, and decided to rephrase it a little bit. This way it is more clear IMO. --- src/backend/optimizer/plan/aqumv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/backend/optimizer/plan/aqumv.c b/src/backend/optimizer/plan/aqumv.c index 5b72a9f6858..7231d1e6b25 100644 --- a/src/backend/optimizer/plan/aqumv.c +++ b/src/backend/optimizer/plan/aqumv.c @@ -174,7 +174,8 @@ answer_query_using_materialized_views(PlannerInfo *root, /* * AQUMV * Currently the data of IVM is always up-to-date if there were. - * Take care of this when IVM defered-fefresh is supported(in SERVERLESS mode). + * However, we place this future-proof condition to take + * care of IVM deferred maintenance/incremental refresh feature. * * Normal materialized views could also be used if its data is up to date. */ From 8f825e99b1993ce0169ebf1958e8bebe5686f932 Mon Sep 17 00:00:00 2001 From: reshke Date: Fri, 16 Aug 2024 15:34:23 +0500 Subject: [PATCH 2/3] Adjust few more places --- src/backend/optimizer/plan/aqumv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/optimizer/plan/aqumv.c b/src/backend/optimizer/plan/aqumv.c index 7231d1e6b25..4f5de7fa73f 100644 --- a/src/backend/optimizer/plan/aqumv.c +++ b/src/backend/optimizer/plan/aqumv.c @@ -694,10 +694,10 @@ void aqumv_adjust_simple_query(Query *viewQuery) * AQUMV * We have to rewrite now before we do the real Equivalent * Transformation 'rewrite'. - * Because actions sotored in rule is not a normal query tree, - * it can't be used directly, ex: new/old realtions used to + * Because actions stored in rule is not a normal query tree, + * it can't be used directly, with exception to new/old relations used to * refresh mv. - * Earse unused relatoins, keep the right one. + * Erase unused relations, keep the right one. */ foreach (lc, viewQuery->rtable) { From fde63eede93e6d646e3ab150fd12cab0c0bd1afb Mon Sep 17 00:00:00 2001 From: reshke Date: Sat, 17 Aug 2024 13:49:42 +0500 Subject: [PATCH 3/3] Put SERVERLESS clarification back --- src/backend/optimizer/plan/aqumv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/optimizer/plan/aqumv.c b/src/backend/optimizer/plan/aqumv.c index 4f5de7fa73f..f3b7751a16e 100644 --- a/src/backend/optimizer/plan/aqumv.c +++ b/src/backend/optimizer/plan/aqumv.c @@ -175,7 +175,7 @@ answer_query_using_materialized_views(PlannerInfo *root, * AQUMV * Currently the data of IVM is always up-to-date if there were. * However, we place this future-proof condition to take - * care of IVM deferred maintenance/incremental refresh feature. + * care of IVM deferred maintenance/incremental refresh feature (in SERVERLESS mode). * * Normal materialized views could also be used if its data is up to date. */