From 778d724e920bff68651b9510693ce2d86d0897f9 Mon Sep 17 00:00:00 2001 From: Luwei <814383175@qq.com> Date: Tue, 10 Sep 2024 19:28:38 +0800 Subject: [PATCH] [enhancement](balance) change unnecessary write locks to read locks in cloud balance --- .../apache/doris/cloud/catalog/CloudTabletRebalancer.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudTabletRebalancer.java b/fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudTabletRebalancer.java index ae34c6b722f7b0..093079437a5c77 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudTabletRebalancer.java +++ b/fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudTabletRebalancer.java @@ -616,10 +616,7 @@ public void loopCloudReplica(Operator operator) { continue; } OlapTable olapTable = (OlapTable) table; - if (!table.writeLockIfExist()) { - continue; - } - + table.readLock(); try { for (Partition partition : olapTable.getAllPartitions()) { for (MaterializedIndex index : partition.getMaterializedIndices(IndexExtState.VISIBLE)) { @@ -630,7 +627,7 @@ public void loopCloudReplica(Operator operator) { } // end for indices } // end for partitions } finally { - table.writeUnlock(); + table.readUnlock(); } } }