From e96f0f98e2e81e215b5f389547b844939dfd494e Mon Sep 17 00:00:00 2001 From: BiteTheDDDDt Date: Thu, 2 Jan 2025 17:47:32 +0800 Subject: [PATCH] do not release tablet_reader on NewOlapScanner::close --- be/src/vec/exec/scan/new_olap_scanner.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/be/src/vec/exec/scan/new_olap_scanner.cpp b/be/src/vec/exec/scan/new_olap_scanner.cpp index d3a05cbb3c2fe6..38b56cba1176ce 100644 --- a/be/src/vec/exec/scan/new_olap_scanner.cpp +++ b/be/src/vec/exec/scan/new_olap_scanner.cpp @@ -524,14 +524,6 @@ Status NewOlapScanner::close(RuntimeState* state) { return Status::OK(); } - // olap scan node will call scanner.close() when finished - // will release resources here - // if not clear rowset readers in read_params here - // readers will be release when runtime state deconstructed but - // deconstructor in reader references runtime state - // so that it will core - _tablet_reader_params.rs_splits.clear(); - _tablet_reader.reset(); RETURN_IF_ERROR(VScanner::close(state)); return Status::OK(); }