Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up profiling features #1578

Open
thpani opened this issue Mar 30, 2022 · 2 comments
Open

Clean up profiling features #1578

thpani opened this issue Mar 30, 2022 · 2 comments
Labels
doc Documentation product-owner-triage This should be triaged by the product owner

Comments

@thpani
Copy link
Collaborator

thpani commented Mar 30, 2022

I'm at a loss about our profiling features:

  • running.md tells me to use --profiling to write profile-rules.txt and points me to check profiling.md.

  • profiling.md however, does not even mention --profiling. Instead, it tells me to use --smtprof to produce profile.csv and visualize it using script/heatmap.py. --smtprof is not documented in running.md, aside from saying that it is incompatible with --profiling=false.

  • On top, we have script/prof.py, which is still on Python 2 and digests log.smt. There's no documentation on this one.

Can someone enlighten me? Also, we should fix the docs.

@thpani thpani added bug doc Documentation labels Mar 30, 2022
@shonfeder
Copy link
Contributor

I think @konnov is most familiar with the profiling?

@konnov
Copy link
Collaborator

konnov commented Mar 31, 2022

Ugh, I am actually not sure about the connection between these two flags. This needs some archaeology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation product-owner-triage This should be triaged by the product owner
Projects
None yet
Development

No branches or pull requests

4 participants