Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen ApolloCLI folder #1057

Closed
wow-such-amazing opened this issue Mar 3, 2020 · 2 comments
Closed

Codegen ApolloCLI folder #1057

wow-such-amazing opened this issue Mar 3, 2020 · 2 comments
Labels
codegen Issues related to or arising from code generation
Milestone
0.24.0

Comments

@wow-such-amazing
Copy link
Contributor

Hi 👋

I have couple questions regarding the new Codegen 🙂

  1. Is it a good practice to add ApolloCLI folder to the .gitignore?
  2. I ran into an issue when my build was failing because I didn't have an empty ApolloCLI folder inside SwiftScripts folder. After I created an empty ApolloCLI folder my build succeeded. I didn't have such folder because I added ApolloCLI to .gitignore. Do you have any ideas how to overcome this problem?

Thank you!
@wow-such-amazing wow-such-amazing changed the title ApolloCLI default folder Codegen ApolloCLI folder Mar 3, 2020
@designatednerd
Copy link
Contributor

  1. Yes, absolutely. Otherwise you wind up checking a ton of JS in to your repo that has nothing to do with your project
  2. I got around this by force-adding an empty .keep file within ApolloCLI to git just to preserve the folder structure, but we should probably just create the folder if it doesn't exist in the longer term.

@designatednerd designatednerd added the codegen Issues related to or arising from code generation label Mar 3, 2020
@wow-such-amazing
Copy link
Contributor Author

Thank you for the reply, I will use .keep file for now then 👍

@designatednerd designatednerd mentioned this issue Mar 6, 2020
Merged
@designatednerd designatednerd added this to the 0.24.0 milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen Issues related to or arising from code generation
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
2 participants
@designatednerd @wow-such-amazing