Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extensions property on GraphQLResult #1348

Closed
paulkite opened this issue Aug 4, 2020 · 7 comments
Closed

extensions property on GraphQLResult #1348

paulkite opened this issue Aug 4, 2020 · 7 comments
Labels
enhancement Issues outlining new things we want to do or things that will make our lives as devs easier networking-stack
Milestone
0.32.0

Comments

@paulkite
Copy link
Contributor

paulkite commented Aug 4, 2020

Hello! Curious if there are any plans to implement the extensions hash map support on GraphQLResult. I see the Android implementation has this and would love to be able to have the same ability to use this as well.

Thanks!
@paulkite paulkite changed the title extensions property on GraphQLResult extensions property on GraphQLResult Aug 4, 2020
@designatednerd
Copy link
Contributor

This is implemented on GraphQLError on our end. Are you using it in a non-error capacity?

@paulkite
Copy link
Contributor Author

paulkite commented Aug 4, 2020

Yes. Our team sends non-error information through extensions.

@designatednerd
Copy link
Contributor

OK - looking at the spec it does appear extensions is allowed at the root of the response.

I'm somewhat swamped at the moment - if you want to make a PR you're more than welcome to (just make sure to add tests!) but I'll try to get to it as I can if not.

@designatednerd designatednerd added enhancement Issues outlining new things we want to do or things that will make our lives as devs easier networking-stack labels Aug 4, 2020
@paulkite
Copy link
Contributor Author

paulkite commented Aug 4, 2020

Thank you so much for the response!

@paulkite
Copy link
Contributor Author

@designatednerd Just curious, what's the usual turnaround on PRs from the community to getting into a release?

@designatednerd
Copy link
Contributor

Usually fairly quick if they're small. It'd almost certainly be faster than waiting for me to have bandwidth 😛

@paulkite paulkite mentioned this issue Aug 27, 2020
Merged
@designatednerd designatednerd added this to the 0.32.0 milestone Sep 8, 2020
@designatednerd
Copy link
Contributor

This shipped as part of 0.32.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issues outlining new things we want to do or things that will make our lives as devs easier networking-stack
Projects
None yet
Milestone
0.32.0
Development

No branches or pull requests
2 participants
@designatednerd @paulkite