Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities in node_modules #1717

Closed
jujusa opened this issue Mar 15, 2021 · 5 comments
Closed

Vulnerabilities in node_modules #1717

jujusa opened this issue Mar 15, 2021 · 5 comments
Milestone

Comments

@jujusa
Copy link

jujusa commented Mar 15, 2021

Report

We've recently added an OWASP vulnerability analysis step to our CI pipelines using DependencyCheck, and it reported two known vulnerabilities in some dependencies of Apollo. Looks like they are related to the JS components so please let me know if there is a better repo to report this to.

  1. Lodash (4.17.20) found in Pods/Apollo/scripts/apollo/node_modules/lodash/package.json CVE-2020-28500, CVE-2021-23337
  2. jQuery (2.1.1) found in Pods/Apollo/scripts/apollo/node_modules/await-to-js/dist/docs/assets/js/main.js CVE-2015-9251, CVE-2019-11358, CVE-2020-11022, CVE-2020-11023

I found a similar issue that was raised in the past here #439

Would it be possible to bump versions for those dependencies so they are not flagged? I'm not a JS expert so not sure how much effort it would be.

Versions

  • apollo-ios SDK version: 0.42.0
  • dependency-check version: 6.0.5

Steps to reproduce

  1. Pod install
  2. Build workspace in Xcode
  3. Run dependency-check
@designatednerd
Copy link
Contributor

Those issues would be happening in the apollo-tooling repo rather than here, though I'd need to update the version of apollo-tooling we're using from the iOS repo to ensure those changes get propagated. It looks like that repo doesn't presently have any warnings on it, but we may need to do a patch release to get all the merged dependency fixes in.

@jujusa
Copy link
Author

jujusa commented Mar 16, 2021

Thank you so much for your quick reply @designatednerd, I have now raised this within the tooling project 🙇

@designatednerd
Copy link
Contributor

Updated version of the CLI will go out with the next minor release (probably tomorrow)

@jujusa
Copy link
Author

jujusa commented May 13, 2021

Thank you for the update. Can't wait to try it 🙂

@AnthonyMDev
Copy link
Contributor

This version has been released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants