Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision Record - Drop SPM support for Xcode versions lower than 12 #1991

Closed
calvincestari opened this issue Oct 13, 2021 · 2 comments · Fixed by #1992
Closed

Decision Record - Drop SPM support for Xcode versions lower than 12 #1991

calvincestari opened this issue Oct 13, 2021 · 2 comments · Fixed by #1992
Labels
decision-record A log of a decision made and all surrounding context.

Comments

@calvincestari
Copy link
Member

calvincestari commented Oct 13, 2021

Status

  • Proposed - Oct 12, 2021
  • Accepted - Oct 14, 2021

Summary

In an April 2021 App Store submission update, Apple required App Store submissions to be built with Xcode 12.

The Package.swift file declares that the minimum version of the Swift tools and Swift language compatibility to process the SPM manifest is Swift 5.3. Swift 5.3 was released with Xcode 12.

We currently also maintain a [email protected] manifest which declares that the minimum Swift version required is 5.2. Swift 5.2 was released with Xcode 11.4.

Proposal

Delete the [email protected] file to require Xcode version 12 or greater for SPM support.

Consequences

Developers using a version of Xcode prior to 12 will not be able to use Swift Package Manager as the dependency manager for Apollo iOS. This is a moot point because since April 26th, 2021, Apple does not accept submissions from any version of Xcode lower than 12.

@calvincestari calvincestari added the decision-record A log of a decision made and all surrounding context. label Oct 13, 2021
@calvincestari
Copy link
Member Author

This might be a premature decision given that I can't find any definitive Xcode version requirements for submitting a Mac app to the App Store. 😕

@designatednerd
Copy link
Contributor

I'm fine with going ahead and dropping this - the vast majority of people who are using this at least have an iOS component, and by this point most folks will have updated to beyond 5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision-record A log of a decision made and all surrounding context.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants