Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ApolloSchemaDownloadConfiguration #2012

Closed
calvincestari opened this issue Nov 1, 2021 · 1 comment
Closed

Refactor ApolloSchemaDownloadConfiguration #2012

calvincestari opened this issue Nov 1, 2021 · 1 comment
Labels
codegen Issues related to or arising from code generation
Milestone
Release 1.0 (Alpha)

Comments

@calvincestari
Copy link
Member

calvincestari commented Nov 1, 2021 •
edited
Loading

There are two parts of work here:

  1. Remove URL parameters in favour of path-based (String) parameters. Paths indicate a file system which better expresses intent of this part of codegen; it also brings ApolloSchemaDownloadConfiguration inline with recent changes to the FileManager extension.
  2. Drop the download timeout property and associated logic in favour of URLSessionConfiguration timeout customization.
@calvincestari calvincestari self-assigned this Nov 1, 2021
@calvincestari calvincestari added 2021-11 codegen Issues related to or arising from code generation labels Nov 1, 2021
@calvincestari calvincestari added this to the Release 1.0 milestone Nov 1, 2021
@calvincestari
Copy link
Member Author

I'll be getting back to this issue once #1981 is done; this work will layer on top of that.

@calvincestari calvincestari mentioned this issue Nov 6, 2021
Merged
@calvincestari calvincestari removed their assignment Nov 18, 2021
@calvincestari calvincestari moved this to Todo in apollo-ios Jan 8, 2022
@calvincestari calvincestari mentioned this issue May 31, 2022
Merged
Repository owner moved this from Todo to Done in apollo-ios May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen Issues related to or arising from code generation
Projects
No open projects
apollo-ios
Status: Done
Milestone
Release 1.0 (Alpha)
Development

No branches or pull requests
2 participants
@hwillson @calvincestari