Generated code produces compile error when accessing "data" dictionary in the "InputDict" struct if the name of the accessed property is "hash"

[Anteo95]

Bug report

Currently there is a compiler error in generated code when accessing "data" dictionary in the "InputDict" struct if the name of the accessed property is "hash".

Versions

• apollo-ios SDK version: 1.0.2
• Xcode version: 14.1 RC
• Swift version: 5.7.1

Steps to reproduce

1. execute generate code command.

Further details

Here is a screenshot of errors produced by the compiler:

I think the reason why this fails is because InputDict has a function:

  public func hash(into hasher: inout Hasher) {
    hasher.combine(data._jsonEncodableValue?._jsonValue)
  }

and that causes the compiler to not be able to find "hash" field through dynamic member lookup.

changing generated code to this removes the compile error:

If there is need for any additional info for solving this issue I will try to answer it here.

[calvincestari]

Hi @Anteo95 👋🏻 - thanks for the bug report. I'll do some more investigation but this looks like another parameter name we'll need to escape or mark as reserved.

[calvincestari]

@Anteo95 thanks your solution. I tried many different things yesterday and it looks like that is the only viable one to fix it completely. It's particularly bothersome that the hash function is not something internal that we could simply rename.

[Anteo95]

@calvincestari no problem, glad I could help!

[calvincestari]

This issue is fixed with the merging of #2607 and will be included with the 1.0.3 release soon.

@Anteo95 I ended up simply removing @dynamicMemberLookup, which made the solution far easier.