Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download schema relative to root url #2610

Closed
Anteo95 opened this issue Oct 26, 2022 · 1 comment · Fixed by #2609
Closed

Download schema relative to root url #2610

Anteo95 opened this issue Oct 26, 2022 · 1 comment · Fixed by #2609
Assignees
Labels
bug Generally incorrect behavior codegen Issues related to or arising from code generation
Milestone

Comments

@Anteo95
Copy link
Contributor

Anteo95 commented Oct 26, 2022

Bug report

Currently, even though rootURL can be provided as parameter to function

  public static func fetch(
    configuration: ApolloSchemaDownloadConfiguration,
    withRootURL rootURL: URL? = nil
  )

it is actually not used internally on all places in the ApolloCodeGen lib where it should be. This causes schema to be downloaded into incorrect folder.

Versions

  • apollo-ios SDK version: 1.0.2
  • Xcode version: 14.1 RC1
  • Swift version: 5.7.1

Steps to reproduce

  1. Try to generate code with ApolloCodeGen
  2. Generated schema ends up in incorrect folder without respecting passed rootURL property

Further details

I have created a pull request that should solve this issue.
#2609

If there is anything else I am missing here please tell me and I will try to answer it.

@calvincestari calvincestari self-assigned this Nov 1, 2022
@calvincestari
Copy link
Member

Thanks for raising the issue @Anteo95 and for the PR contribution. I'll take a look at the test failures otherwise we should be good to get this included in the next 1.0.3 release.

@calvincestari calvincestari added bug Generally incorrect behavior codegen Issues related to or arising from code generation labels Nov 1, 2022
@calvincestari calvincestari added this to the Release 1.0.3 milestone Nov 1, 2022
@calvincestari calvincestari linked a pull request Nov 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Generally incorrect behavior codegen Issues related to or arising from code generation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants