@skip is not working when query has default value

[alexisbronchart]

Summary

Fragments annotated with @skip are not included in the response when query has default value for the variable skip relies on.

Version

1.0.6

Steps to reproduce the behavior

Considering this query:

query SomeDetails(
  $id: ID!
  $skipFragment: Boolean = false
) {
  somedata(id: $id) {
    ...SomeFragment @skip(if: $skipFragment)
  }
}

and fetching it like so:

let skip = false
let query = SomeDetailsQuery(
    id: 42,
    skipFragment: .some(skip)
)
let response = try await apollo.fetch(query: query)

then response.somedata.fragment.someFragment will always be nil.
It used to work in 0.53.
If I change the skipFragment var definition from $skipFragment: Boolean = false to $skipFragment: Boolean! then it starts working again as expected.

Logs

No response

Anything else?

No response

[AnthonyMDev]

I think this is a duplicate of #2690, which has been fixed on the main branch by PR #2794. The next patch release will include this fix. You can rely on the main branch in the mean time!

[calvincestari]

@alexisbronchart - please do retry your issue using the main branch. I'd like to know whether you're still having a problem using the fixed code from PR #2794; the conditional type looks to be exactly the same, i.e.: nullable.

[alexisbronchart]

I can confirm the issue is fixed on main! Thanks!

[calvincestari]

Great to hear. We've got a couple other issues we want to get out with 1.0.7 but it will be released very soon.