Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is operationIDsFileGenerator.generate called twice when itemsToGenerate is all ? #3224

Closed
jimisaacs opened this issue Sep 18, 2023 · 2 comments
Closed

Why is operationIDsFileGenerator.generate called twice when itemsToGenerate is all ? #3224

jimisaacs opened this issue Sep 18, 2023 · 2 comments
Labels
question Issues that have a question which should be addressed

Comments

@jimisaacs
Copy link
Contributor

jimisaacs commented Sep 18, 2023 •
edited
Loading

Question

I am in this code trying to make contributions, but I'm also very confused why I'm trying to support the double calls to operationIDsFileGenerator?

Seems like all the things to generate an operation manifest happen in ApolloCodegen.build, then they happen again in ApolloCodegen.generateFiles, yet ApolloCodegen.generateFiles is called from ApolloCodegen.build?

What am I missing?
@jimisaacs jimisaacs added the question Issues that have a question which should be addressed label Sep 18, 2023
@jimisaacs
Copy link
Contributor Author

jimisaacs commented Sep 18, 2023 •
edited
Loading

I went ahead and made a PR here #3225

@jimisaacs jimisaacs changed the title Why is operationIDsFileGenerator?.generate call twice when itemsToGenerate is all ? Why is operationIDsFileGenerator.generate called twice when itemsToGenerate is all ? Sep 18, 2023
@BobaFetters
Copy link
Member

Closed by #3225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Issues that have a question which should be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimisaacs @BobaFetters