-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS network crash #6400
Comments
Looks like it... Maybe it's somewhere deeper though as I think I tried last time in a sample app and wasn't able to reproduce. Does that happen every time for you? |
Specifically, we're seeing the issue when we have Airplane Mode enabled and we add Swift interceptors to the Apollo client. If the interceptors are defined in our KMP xcframework instead, the issue is resolved. Our setup in Swift is along the lines of this:
Will try and get an end to end sample project together this week that reproduces the exact issue. |
I can reproduce here but sadly don't have a great solution so far. The contract of |
This would be a pain, but could we change |
@edenman I managed to make exceptions work by broadening the possible exceptions from The exception arrives in Kotlin-land as a I'll give it a couple of days to settle, make sure this does not disrupt existing users too much but I think it should be acceptable. Let me know if that'd work for you. |
Version
4.0.1
Summary
I filed this before but don't have permission to re-open #6201 and we got a little more info. Here's the stack:
None of our app's code is involved afaict. Does
ApolloCall.execute
need a@Throws
annotation to keep ios from crashing?Steps to reproduce the behavior
No response
Logs
The text was updated successfully, but these errors were encountered: