chore: set animation scale via settings for api level 26+ (#1007)

* chore: use --no-window-animation to disable animation for api level 26+

* simplified

* fix lint

* ignore only false

* use settings command

* rename

* append description

* bump the adb

* Update driver.ts

* Update README.md

* remove adb.setanimationscale

* Update README.md

Author: KazuCocoa

README.md

@@ -188,7 +188,7 @@ appium:chromeOptions | A mapping, that allows to customize chromedriver options.
 Capability Name | Description
 --- | ---
 appium:disableSuppressAccessibilityService | Being set to `true` tells the instrumentation process to not suppress accessibility services during the automated test. This might be useful if your automated test needs these services. `false` by default
-appium:disableWindowAnimation | To avoid flakiness google [recommends](https://developer.android.com/training/testing/espresso/setup#set-up-environment) to disable the window animation of the Android device under test when running espresso test. `true` by default
+appium:disableWindowAnimation | To avoid flakiness google [recommends](https://developer.android.com/training/testing/espresso/setup#set-up-environment) to disable the window animation of the Android device under test when running espresso test. Animation state is restored automatically after the session is stopped if it was enabled before it has started. The restore method may not work if the session ends unexpectedly. `true` by default
 appium:timeZone | Overrides the current device's time zone since the driver version 2.38.0. This change is preserved until the next override. The time zone identifier must be a valid name from the list of [available time zone identifiers](https://en.wikipedia.org/wiki/List_of_tz_database_time_zones), for example `Europe/Kyiv`
 
 

lib/driver.ts

@@ -409,8 +409,7 @@ export class EspressoDriver extends AndroidDriver implements ExternalDriver<
     }
     await this.initDevice();
 
-    // https://github.com/appium/appium-espresso-driver/issues/72
-    // default state is window animation disabled
+    // Default state is window animation disabled.
     await this.setWindowAnimationState(this.caps.disableWindowAnimation === false);
 
     // set actual device name, udid
@@ -479,6 +478,13 @@ export class EspressoDriver extends AndroidDriver implements ExternalDriver<
     await this.addDeviceInfoToCaps();
   }
 
+  /**
+   * Turn on or off animation scale.
+   * '--no-window-animation' instrument argument for Espresso disables window animations,
+   * but it does not bring the animation scale back to the pre-instrument process start state in Espresso
+   * unlike Appium UIA2 driver case. We want to disable/enable the animation scale only in an appium espresso session as possible.
+   * @param isEnabled
+   */
   async setWindowAnimationState(isEnabled: boolean): Promise<void> {
     const isAnimationOn = await this.adb.isAnimationOn();
     const shouldDisableAnimation = !isEnabled && isAnimationOn;

package.json

@@ -72,11 +72,11 @@
     "npm-shrinkwrap.json"
   ],
   "dependencies": {
-    "appium-adb": "^12.2.0",
+    "appium-adb": "^12.4.0",
     "appium-android-driver": "^9.6.0",
     "asyncbox": "^3.0.0",
     "bluebird": "^3.5.0",
-    "io.appium.settings": "^5.7.2",
+    "io.appium.settings": "^5.10.0",
     "lodash": "^4.17.11",
     "portscanner": "^2.1.1",
     "source-map-support": "^0.x",