[Framework] remove unnecessary lines creating resource acct signer

Author: lightmark

aptos-move/framework/aptos-framework/doc/resource_account.md

@@ -356,8 +356,7 @@ the SignerCapability.
         <a href="../../aptos-stdlib/doc/simple_map.md#0x1_simple_map_destroy_empty">simple_map::destroy_empty</a>(store);
     };
 
-    <b>let</b> resource = <a href="account.md#0x1_account_create_signer_with_capability">account::create_signer_with_capability</a>(&resource_signer_cap);
-    <a href="account.md#0x1_account_rotate_authentication_key_internal">account::rotate_authentication_key_internal</a>(&resource, <a href="resource_account.md#0x1_resource_account_ZERO_AUTH_KEY">ZERO_AUTH_KEY</a>);
+    <a href="account.md#0x1_account_rotate_authentication_key_internal">account::rotate_authentication_key_internal</a>(resource, <a href="resource_account.md#0x1_resource_account_ZERO_AUTH_KEY">ZERO_AUTH_KEY</a>);
     resource_signer_cap
 }
 </code></pre>

aptos-move/framework/aptos-framework/sources/resource_account.move

@@ -18,12 +18,11 @@
 ///
 /// Code snippets to help:
 /// ```
-/// fun init_module(source: &signer) {
+/// fun init_module(resource: &signer) {
 ///   let dev_address = @DEV_ADDR;
-///   let signer_cap = retrieve_resource_account_cap(&source, dev_address);
-///   let lp_signer = create_signer_with_capability(&signer_cap);
+///   let signer_cap = retrieve_resource_account_cap(resource, dev_address);
 ///   let lp = LiquidityPoolInfo { signer_cap: signer_cap, ... };
-///   move_to(&lp_signer, lp);
+///   move_to(resource, lp);
 /// }
 /// ```
 ///
@@ -182,8 +181,7 @@ module aptos_framework::resource_account {
             simple_map::destroy_empty(store);
         };
 
-        let resource = account::create_signer_with_capability(&resource_signer_cap);
-        account::rotate_authentication_key_internal(&resource, ZERO_AUTH_KEY);
+        account::rotate_authentication_key_internal(resource, ZERO_AUTH_KEY);
         resource_signer_cap
     }
 

aptos-move/framework/aptos-token/doc/token.md

@@ -2212,6 +2212,8 @@ Burn a token by the token owner
     <a href="token.md#0x3_token_assert_tokendata_exists">assert_tokendata_exists</a>(creator, token_data_id);
     <b>let</b> all_token_data = &<b>mut</b> <b>borrow_global_mut</b>&lt;<a href="token.md#0x3_token_Collections">Collections</a>&gt;(token_data_id.creator).token_data;
     <b>let</b> token_data = <a href="../../aptos-framework/../aptos-stdlib/doc/table.md#0x1_table_borrow_mut">table::borrow_mut</a>(all_token_data, token_data_id);
+    // cannot change maximum from 0 and cannot change maximum <b>to</b> 0
+    <b>assert</b>!(token_data.maximum != 0 && maximum != 0, <a href="../../aptos-framework/../aptos-stdlib/../move-stdlib/doc/error.md#0x1_error_invalid_argument">error::invalid_argument</a>(<a href="token.md#0x3_token_EINVALID_MAXIMUM">EINVALID_MAXIMUM</a>));
     <b>assert</b>!(maximum &gt;= token_data.supply, <a href="../../aptos-framework/../aptos-stdlib/../move-stdlib/doc/error.md#0x1_error_invalid_argument">error::invalid_argument</a>(<a href="token.md#0x3_token_EINVALID_MAXIMUM">EINVALID_MAXIMUM</a>));
     <b>assert</b>!(token_data.mutability_config.maximum, <a href="../../aptos-framework/../aptos-stdlib/../move-stdlib/doc/error.md#0x1_error_permission_denied">error::permission_denied</a>(<a href="token.md#0x3_token_EFIELD_NOT_MUTABLE">EFIELD_NOT_MUTABLE</a>));
     token_data.maximum = maximum;

aptos-move/move-examples/mint_nft/sources/minting.move

@@ -120,17 +120,16 @@ module mint_nft::minting {
 
         // change source_addr to the actual account that created the resource account
         let resource_signer_cap = resource_account::retrieve_resource_account_cap(resource_account, @source_addr);
-        let resource_signer = account::create_signer_with_capability(&resource_signer_cap);
 
         // create the nft collection
         let maximum_supply = 0;
         let mutate_setting = vector<bool>[ false, false, false ];
-        let resource_account_address = signer::address_of(&resource_signer);
-        token::create_collection(&resource_signer, collection_name, description, collection_uri, maximum_supply, mutate_setting);
+        let resource_account_address = signer::address_of(resource_account);
+        token::create_collection(resource_account, collection_name, description, collection_uri, maximum_supply, mutate_setting);
 
         // create a token data id to specify which token will be minted
         let token_data_id = token::create_tokendata(
-            &resource_signer,
+            resource_account,
             collection_name,
             token_name,
             string::utf8(b""),
@@ -156,7 +155,7 @@ module mint_nft::minting {
             token_data_id,
             expiration_timestamp,
             minting_enabled: true,
-            token_minting_events: account::new_event_handle<TokenMintingEvent>(&resource_signer),
+            token_minting_events: account::new_event_handle<TokenMintingEvent>(resource_account),
         });
     }
 

aptos-move/move-examples/resource_account/sources/simple_defi.move

@@ -37,9 +37,8 @@ module resource_account::simple_defi {
     fun init_module(account: &signer) {
         // store the capabilities within `ModuleData`
         let resource_signer_cap = resource_account::retrieve_resource_account_cap(account, @source_addr);
-        let resource_signer = account::create_signer_with_capability(&resource_signer_cap);
         let (burn_cap, freeze_cap, mint_cap) = coin::initialize<ChloesCoin>(
-            &resource_signer,
+            account,
             string::utf8(b"Chloe's Coin"),
             string::utf8(b"CCOIN"),
             8,