Skip to content

Commit 7ff4f18

Browse files
authored
backup-compactor: Ignore failure in backing up .meta file (#16043)
1 parent 436f6ab commit 7ff4f18

File tree

1 file changed

+11
-2
lines changed
  • storage/backup/backup-cli/src/coordinators

1 file changed

+11
-2
lines changed

storage/backup/backup-cli/src/coordinators/backup.rs

+11-2
Original file line numberDiff line numberDiff line change
@@ -453,9 +453,18 @@ impl BackupCompactor {
453453
let (to_move, compaction_meta) =
454454
self.update_compaction_timestamps(&mut metaview, files, new_files)?;
455455
for file in to_move {
456-
// directly return if any of the backup task fails
457456
info!(file = file, "Backup metadata file.");
458-
self.storage.backup_metadata_file(&file).await?
457+
self.storage
458+
.backup_metadata_file(&file)
459+
.await
460+
.map_err(|err| {
461+
error!(
462+
file = file,
463+
error = %err,
464+
"Backup metadata file failed, ignoring.",
465+
)
466+
})
467+
.ok();
459468
}
460469
// save the metadata compaction timestamps
461470
let metadata = Metadata::new_compaction_timestamps(compaction_meta);

0 commit comments

Comments
 (0)