ModbusRTUClient.setTimeout does not set timeout of Stream class

[cheetor5923]

When called, ModbusRTUClient.setTimeout does not propagate the timeout to it's associated Stream class.

[bobemoe]

I'm having trouble with this too. It seems to be taking 1500ms to timeout by default, which is strange to begin with as the default timeout appears to be 1000ms!

ArduinoModbus/src/ModbusRTUClient.cpp

Lines 29 to 35 in 02abf6d

	ModbusRTUClientClass::ModbusRTUClientClass() :
	ModbusClient(1000)
	{
	}
	ModbusRTUClientClass::ModbusRTUClientClass(RS485Class& rs485) :
	ModbusClient(1000), _rs485(&rs485)

I've started looking into the code, and it looks like ArduinoModbus is passing the args as seconds and milliseconds:

ArduinoModbus/src/ModbusClient.cpp

Line 422 in 02abf6d

modbus_set_response_timeout(_mb, _timeout / 1000, (_timeout % 1000) * 1000);

while libmodbus is expecting the values as seconds and microseconds:

ArduinoModbus/src/libmodbus/modbus.c

Lines 1693 to 1696 in 02abf6d

	int modbus_set_response_timeout(modbus_t *ctx, uint32_t to_sec, uint32_t to_usec)
	{
	if (ctx == NULL ||
	(to_sec == 0 && to_usec == 0) || to_usec > 999999) {

I'm not sure this is the current issue, as I'm trying to set it to 50ms, and even if that was passed over as 50us I would expect to see an almost instant timeout, however I'm still getting 1500ms timeout.

What's going on here!?