Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behavior between helm values and valuesObject #19781

Open
3 tasks done
fad3t opened this issue Sep 4, 2024 · 1 comment
Open
3 tasks done

Different behavior between helm values and valuesObject #19781

fad3t opened this issue Sep 4, 2024 · 1 comment
Labels
bug Something isn't working component:diffing component:helm version:2.11 Latest confirmed affected version is 2.11

Comments

@fad3t
Copy link

fad3t commented Sep 4, 2024

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

In one of my applications, I'm overriding some values with the null (~) value.
I noticed I'm getting a different behavior when using values vs valuesObject in my Helm application. ArgoCD correctly understands it when using values, however it looks totally ignored when I'm switching to valuesObject.

Note I'm not using any subchart here.

To Reproduce

This one works as expected:

<..snipped..>
source:
  repoURL: "https://example.com"
  chart: "my-chart"
  targetRevision: "1.0.0"
  helm:
    values: |
      quota: ~
      limitRange: ~

This one does not:

<..snipped..>
source:
  repoURL: "https://example.com"
  chart: "my-chart"
  targetRevision: "1.0.0"
  helm:
    valuesObject:
      quota: ~
      limitRange: ~

And this is the template used for the limit range for example:

{{- with .Values.limitRange }}
---
apiVersion: v1
kind: LimitRange
metadata:
  name: {{ include "my-chart.namespace" $ }}-limits
  labels:
    {{- include "my-chart.labels" $ | nindent 4 }}
spec:
  limits:
  <..snipped..>
{{- end }}

Expected behavior

I'm expecting both options to provide identical results, i.e. override the value with null.

Version

{
    "Version": "v2.11.7+e4a0246",
    "BuildDate": "2024-07-24T09:33:49Z",
    "GitCommit": "e4a0246c4d920bc1e5ee5f9048a99eca7e1d53cb",
    "GitTreeState": "clean",
    "GoVersion": "go1.21.10",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.2.1 2023-10-19T20:13:51Z",
    "HelmVersion": "v3.14.4+g81c902a",
    "KubectlVersion": "v0.26.11",
    "JsonnetVersion": "v0.20.0"
}
@fad3t fad3t added the bug Something isn't working label Sep 4, 2024
@andrii-korotkov-verkada andrii-korotkov-verkada added the version:2.11 Latest confirmed affected version is 2.11 label Nov 11, 2024
@sathieu
Copy link
Contributor

sathieu commented Dec 13, 2024

Dup of #16312 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:diffing component:helm version:2.11 Latest confirmed affected version is 2.11
Projects
None yet
Development

No branches or pull requests

4 participants