Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Asciidoctor PDF as a Prawn view #53

Closed
mojavelinux opened this issue Sep 17, 2014 · 3 comments
Closed

Refactor Asciidoctor PDF as a Prawn view #53

mojavelinux opened this issue Sep 17, 2014 · 3 comments
Assignees
Labels
tabled Viable requests or ideas, but there's no time to work on them right now.

Comments

@mojavelinux
Copy link
Member

Make use of the Prawn "view" API instead of extending Prawn to isolate the Asciidoctor PDF methods from Prawn core.

For more information, refer to https://github.com/prawnpdf/prawn/blob/master/lib/prawn/view.rb

@mojavelinux
Copy link
Member Author

More information about Prawn::View can be found in the 1.3.0 release notes:

https://github.com/prawnpdf/prawn/wiki/CHANGELOG#added-the-prawnview-mixin-for-using-prawns-dsl-in-your-own-classes

@mojavelinux
Copy link
Member Author

I didn't know Prawn very well when I started it, so we ended up with a monolithic subclass of Document. We really need to upgrade Prawn and migrate to a Prawn View. The first step is a simple demonstration of how that might look. Don't worry about all the node handlers to start with. We need a vision.

@mojavelinux
Copy link
Member Author

The view is now documented in the manual. See https://github.com/prawnpdf/prawn/blob/master/manual/basic_concepts/view.rb

@mojavelinux mojavelinux modified the milestones: v1.5.0, future Sep 18, 2019
@graphitefriction graphitefriction added tabled Viable requests or ideas, but there's no time to work on them right now. and removed improvement labels May 16, 2022
@graphitefriction graphitefriction removed this from the future milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tabled Viable requests or ideas, but there's no time to work on them right now.
Projects
None yet
Development

No branches or pull requests

2 participants