Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLW3201: Customize error message for dunder methods removed with Python 3 #12883

Closed
MichaReiser opened this issue Aug 14, 2024 · 1 comment · Fixed by #13194
Closed

PLW3201: Customize error message for dunder methods removed with Python 3 #12883

MichaReiser opened this issue Aug 14, 2024 · 1 comment · Fixed by #13194
Assignees
Labels
good first issue Good for newcomers rule Implementing or modifying a lint rule

Comments

@MichaReiser
Copy link
Member

MichaReiser commented Aug 14, 2024

#12607 proposed a new dango-model-with-dunder-unicode rule that flags any __unicode__ dunder method. We realized that this is already covered by PLW3201 (preview), but the error message could be improved to state that a dunder method is Python2 only explicitly.

The comments list a few dunder methods that were removed with python 3:

We should change PLW3201 to use a custom error message for any dunder method that was removed with Python 3.

@MichaReiser MichaReiser added good first issue Good for newcomers rule Implementing or modifying a lint rule labels Aug 14, 2024
@iamlucasvieira
Copy link
Contributor

Hey @MichaReiser, I've picked up this issue and opened a pull request. This is my first contribution to the project, so I hope I've followed the contributing guidelines correctly. Any feedback is appreciated 😊!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants