Skip to content

Commit 9cca6e4

Browse files
committed
Enable linters previously failing with generics
Remove all explicit disable entries for linters listed as incompatible with generics. refs GH-844
1 parent 8653f01 commit 9cca6e4

File tree

3 files changed

+0
-66
lines changed

3 files changed

+0
-66
lines changed

oldstable/.golangci.yml

-22
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,6 @@ linters:
4747
- stylecheck
4848
- unconvert
4949

50-
disable:
51-
# Incompatible with Go 1.18 (GH-568, GH-681)
52-
# https://github.com/golangci/golangci-lint/issues/2649
53-
- rowserrcheck
54-
- sqlclosecheck
55-
- structcheck
56-
- wastedassign
57-
5850
#
5951
# Disable govet:fieldalignment, re-enable deprecated maligned linter until the
6052
# Go team offers more control over the types of checks provided by the
@@ -84,17 +76,3 @@ linters-settings:
8476
# See https://github.com/atc0005/go-ci/issues/302 for more information.
8577
#
8678
- fieldalignment
87-
88-
# Incompatible with Go 1.18 (GH-568)
89-
# https://github.com/golangci/golangci-lint/issues/2649
90-
- nilness
91-
- unusedwrite
92-
93-
gocritic:
94-
disable:
95-
# Incompatible with Go 1.18 (GH-568)
96-
# https://github.com/golangci/golangci-lint/issues/2649
97-
- hugeParam
98-
- rangeValCopy
99-
- typeDefFirst
100-
- paramTypeCombine

stable/.golangci.yml

-22
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,6 @@ linters:
4747
- stylecheck
4848
- unconvert
4949

50-
disable:
51-
# Incompatible with Go 1.18 (GH-568, GH-681)
52-
# https://github.com/golangci/golangci-lint/issues/2649
53-
- rowserrcheck
54-
- sqlclosecheck
55-
- structcheck
56-
- wastedassign
57-
5850
#
5951
# Disable govet:fieldalignment, re-enable deprecated maligned linter until the
6052
# Go team offers more control over the types of checks provided by the
@@ -84,17 +76,3 @@ linters-settings:
8476
# See https://github.com/atc0005/go-ci/issues/302 for more information.
8577
#
8678
- fieldalignment
87-
88-
# Incompatible with Go 1.18 (GH-568)
89-
# https://github.com/golangci/golangci-lint/issues/2649
90-
- nilness
91-
- unusedwrite
92-
93-
gocritic:
94-
disable:
95-
# Incompatible with Go 1.18 (GH-568)
96-
# https://github.com/golangci/golangci-lint/issues/2649
97-
- hugeParam
98-
- rangeValCopy
99-
- typeDefFirst
100-
- paramTypeCombine

unstable/.golangci.yml

-22
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,6 @@ linters:
5959
- stylecheck
6060
- unconvert
6161

62-
disable:
63-
# Incompatible with Go 1.18 (GH-568, GH-681)
64-
# https://github.com/golangci/golangci-lint/issues/2649
65-
- rowserrcheck
66-
- sqlclosecheck
67-
- structcheck
68-
- wastedassign
69-
7062
#
7163
# Disable govet:fieldalignment, re-enable deprecated maligned linter until the
7264
# Go team offers more control over the types of checks provided by the
@@ -97,17 +89,3 @@ linters-settings:
9789
# See https://github.com/atc0005/go-ci/issues/302 for more information.
9890
#
9991
- fieldalignment
100-
101-
# Incompatible with Go 1.18 (GH-568)
102-
# https://github.com/golangci/golangci-lint/issues/2649
103-
- nilness
104-
- unusedwrite
105-
106-
gocritic:
107-
disable:
108-
# Incompatible with Go 1.18 (GH-568)
109-
# https://github.com/golangci/golangci-lint/issues/2649
110-
- hugeParam
111-
- rangeValCopy
112-
- typeDefFirst
113-
- paramTypeCombine

0 commit comments

Comments
 (0)