Allow using a custom API client in rvk_methods
#27
Labels
api
This applies to the `rvk` crate (or to the `api`/`error` modules before the crate split)
enhancement
New feature or request
good first issue
Good for newcomers
methods
This applies to the `rvk_methods` crate (or to the `methods` module before the crate split)
Summary
Allow using a custom API client in
rvk_methods
instead of justrvk::APIClient
.Suggested solution
This will likely involve creating a trait that has the necessary function,
call_method
, and implementing that trait forrvk::APIClient
.Avoiding
rvk_methods
depending onrvk
A possible solution for this may be to add a new crate like
rvk_traits
for this purpose (and also move theParams
type alias there, although it might be unnecessary and should rather be entirely removed).Additionally,
rvk_methods::supported_api_client
would need to be removed.Both
rvk_methods
andrvk
would depend onrvk_traits
(the former—to use it, the latter—to implement the trait).Unresolved questions
rvk_traits
name good enough or should a better one be used (e.g.rvk_core
)?The text was updated successfully, but these errors were encountered: