Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testVersion from the ruleset #66

Open
slaFFik opened this issue Feb 22, 2025 · 0 comments
Open

Remove testVersion from the ruleset #66

slaFFik opened this issue Feb 22, 2025 · 0 comments
Labels

Comments

@slaFFik
Copy link
Member

slaFFik commented Feb 22, 2025

Expected Behavior

In my project I want to be able to change the testVersion for PHPCompatibility coding standard to use.

Some of my plugins require PHP 7.2, others - PHP 7.4.

Current Behavior

According to
phpDocumentor/coding-standard#32 (comment)

it's not possible to override the testVersion set in the ruleset upstream.

And I spent unreasonable amount of time confirming this behavior before I found that comment.

Possible Solution

Remove this line from here https://github.com/awesomemotive/wpforms-phpcs/blob/main/WPForms/ruleset.xml#L17

<config name="testVersion" value="7.1-"/>

For WPForms, you can set this value in its local phpcs.xml file (which you already have done).

@slaFFik slaFFik added the bug label Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant