Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fasthttp #133

Closed
fpruitt2 opened this issue Jul 16, 2019 · 4 comments
Closed

Support for fasthttp #133

fpruitt2 opened this issue Jul 16, 2019 · 4 comments

Comments

@fpruitt2
Copy link

Background

fasthttp is an alternative to Go's native net/http network library. It is written to be significantly more performant at scale; in some cases, it is ~10x faster than the standard library. It is used widely and is well-maintained.

The Ask

It would be helpful if aws-xray-sdk-go could work out-of-the-box with fasthttp. The interface in the request handlers is different enough to make it not trivial to use as-is.

Links

fasthttp
net/http-->fasthttp adaptor

@ss2305
Copy link

ss2305 commented Jul 16, 2019

@fpruitt2 We appreciate your input and will consider adding it to our roadmap.

@fpruitt2
Copy link
Author

An acceptable alternative would be decoupling the tracking of a request's data from a specific http library-- being able to (easily) manually set up request tracking would be great!

@ss2305
Copy link

ss2305 commented Jul 16, 2019

@fpruitt2 We would be happy to review any PRs if you want to contribute on this.

@bhautikpip
Copy link
Contributor

fasthttp instrumentation support PR (#295 ) is merged and released so closing out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants