Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page.js to latest #21

Open
ayamflow opened this issue Mar 24, 2015 · 2 comments
Open

Update page.js to latest #21

ayamflow opened this issue Mar 24, 2015 · 2 comments
Assignees

Comments

@ayamflow
Copy link
Owner

Some fixes are pretty nice like the context.params finally being a real object.
Need to check that it still passes the vue-route tests though.

@ayamflow ayamflow self-assigned this Mar 24, 2015
@inear
Copy link

inear commented Mar 31, 2015

The new version of path-to-regexp in latest page.js caused my app to init in a infinite loop and freeze the browser. The page-router did not recognise my routes so falled back on the default behavior. It turned out that it was because I used base = '/' in the settings. If that is the correct behaviour, maybe add some check so that onDefaultRouteis not called in a loop if no other routes is present. Or just ignore base if it's the root. I noticed this when I had to wipe node_modules and page updated itself.

@ayamflow
Copy link
Owner Author

Ah, thanks for the catch!
Yeah I think base the base shouldn't have trailing slash, I should add something about that in the doc or parse it myself - I guess it makes more sens to have / that .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants