Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI to the project #77

Open
CameronDiver opened this issue Apr 14, 2020 · 1 comment
Open

Add a CLI to the project #77

CameronDiver opened this issue Apr 14, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request Parked Implementation has stopped

Comments

@CameronDiver
Copy link
Contributor

Depends on: #75 and #76

Add a binary which people can use, like so:

livepush .

which will either attach to a running container, or build another and begin the livepush process. This will allow greater adoption, as it won't require any further integration.

@CameronDiver CameronDiver added the enhancement New feature or request label Apr 14, 2020
@CameronDiver CameronDiver self-assigned this Apr 14, 2020
@CameronDiver
Copy link
Contributor Author

This may be a little more complicated than I first expected. Because we now have to build the container in some cases, we need some method of describing build arguments for the daemon. Luckily there aren't too many, and while it would be an exercise in yak-shaving it's doable. We'd then need to start a container, and there's a load more options available there, which we'd need to parse and convert into docker remote api calls.

The alternative looks to be using docker command line calls, and passing the arguments directly to the docker CLI tool. Perhaps it's better to not be involved at the build stage in that case, and instead attach to a running container, but this leaves the question of how we preprocess a Dockerfile that contains livepush directives.

A possible way of doing this:

livepush process Dockerfile | docker build . -f -

That is, have livepush process the dockerfile, and Docker read it from stdin. The user would start the container as normal, and then do a livepush attach <containerid>.

More UX thought is needed before we move forward with this feature.

@CameronDiver CameronDiver added Needs more investigation The actual problem is unclear, and more investigation is needed for a fix Parked Implementation has stopped and removed Needs more investigation The actual problem is unclear, and more investigation is needed for a fix labels Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Parked Implementation has stopped
Projects
None yet
Development

No branches or pull requests

1 participant