Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 5.6 support #130

Closed
jilster opened this issue Feb 8, 2018 · 2 comments
Closed

Laravel 5.6 support #130

jilster opened this issue Feb 8, 2018 · 2 comments

Comments

@jilster
Copy link
Contributor

jilster commented Feb 8, 2018

Hi! I am upgrading to Laravel 5.6 and laravel-dynamodb is expecting Laravel 5.5.*. I know Laravel 5.6 is very fresh (released yesterday), but are there any plans for supporting it? It would be great if there were. Thanks in advance!
@baopham
Copy link
Owner

baopham commented Feb 8, 2018

We just need to do a thorough testing and ensure 5.6 didn't introduce any breaking changes for us. Feel free to make a PR and test.

@jilster
Copy link
Contributor Author

jilster commented Feb 8, 2018

Done: #131

But like i said in the description of the PR itself, it works for me and i don't expect any problems, but my application does not use all functionality in laravel-dynamodb.

@baopham baopham closed this as completed in b022954 Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baopham