Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: allow multiple modules in one git repo #46

Closed
tetromino opened this issue Feb 3, 2023 · 5 comments
Closed

FR: allow multiple modules in one git repo #46

tetromino opened this issue Feb 3, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@tetromino
Copy link

It was suggested that https://github.com/bazelbuild/bazel-skylib could adopt publish-to-bcr to simplify the maintainer's workflow.

The bazel-skylib git repo builds two separate Bazel modules: bazel_skylib and bazel_skylib_gazelle_plugin. The release process generates two separate release tarballs via rules_pkg (bazel-skylib-$VERSION.tar.gz and bazel-skylib-gazelle-plugin-$VERSION.tar.gz - see https://github.com/bazelbuild/bazel-skylib/releases/tag/1.4.0 for example) which then should be added to BCR in one commit (e.g. bazelbuild/bazel-central-registry#403) because bazel_skylib_gazelle_plugin depends on bazel_skylib of the same version.

I am wondering if publish-to-bcr could accomodate this setup. It would require breaking the assumption that there is a 1-1 mapping between git repo and module.

One way to do it might be to allow subdirectories in the top-level .bcr template dir, with each subdir corresponding to a separate module.

@kormide
Copy link
Collaborator

kormide commented Apr 6, 2023

I would like to be able to support skylib. I'll scope out some solutions and try to schedule some time this month to work on this.

@aignas
Copy link

aignas commented Apr 20, 2023

rules_python_gazelle_plugin is also a separate submodule in the repo, so this work would help that too.

@chrislovecnm
Copy link

Where is the entry point for this code? I am happy modify bcr to support more than one module.

@kormide
Copy link
Collaborator

kormide commented Apr 24, 2023

Where is the entry point for this code? I am happy modify bcr to support more than one module.

The entrypoint is the github webhook: https://github.com/bazel-contrib/publish-to-bcr/blob/main/src/application/cloudfunction/github-webhook-entrypoint.ts

@kormide
Copy link
Collaborator

kormide commented May 19, 2023

Added support in 11a22c4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants