-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When initial build fails, ibazel should exit #2
Comments
I've several times found myself writing |
True, I've also found the asymmetry of bailing out after a failed build annoying. @mprobst do you have a strong case for that behavior? |
I think this should only fail if the query fails (i.e. if bazel-watcher doesn't know what to watch). |
Here's a confusing case: I do It feels like either ibazel should exit if first build is not successful, or else |
$ ibazel build //example:all
Error running Bazel exit status 7
Building //example:all
Files changed rebuilding...
ERROR: while parsing '//example:all': no such package 'example': BUILD file not found on package path.
INFO: Elapsed time: 0.182s
Build error: exit status 1
[ tool is now apparently hung ]
I think it's better to exit in this case (like iblaze does)
The text was updated successfully, but these errors were encountered: