Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When initial build fails, ibazel should exit #2

Closed
alexeagle opened this issue May 19, 2017 · 4 comments
Closed

When initial build fails, ibazel should exit #2

alexeagle opened this issue May 19, 2017 · 4 comments

Comments

@alexeagle
Copy link
Contributor

$ ibazel build //example:all
Error running Bazel exit status 7
Building //example:all
Files changed rebuilding...
ERROR: while parsing '//example:all': no such package 'example': BUILD file not found on package path.
INFO: Elapsed time: 0.182s
Build error: exit status 1
[ tool is now apparently hung ]

I think it's better to exit in this case (like iblaze does)

@achew22
Copy link
Member

achew22 commented Jun 1, 2017

I've several times found myself writing while true; do iblaze build $target; done in order to try and fix up some vexing syntax errors (usually error prone yelling at me 😉). What would you think about bailing if the query fails but not if the build/test/run fails?

@alexeagle
Copy link
Contributor Author

True, I've also found the asymmetry of bailing out after a failed build annoying. @mprobst do you have a strong case for that behavior?

@mprobst
Copy link
Contributor

mprobst commented Jun 1, 2017

I think this should only fail if the query fails (i.e. if bazel-watcher doesn't know what to watch).

@alexeagle
Copy link
Contributor Author

Here's a confusing case: I do
ibazel run :devserver
and there is a compile error. My devserver is not started. But, ibazel is still running.
Now I fix the compile error, ibazel reports success. But the devserver is still not running.

It feels like either ibazel should exit if first build is not successful, or else ibazel run should have a special case that it starts the binary on the first successful build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants