Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File changes beyond the first are not detected on Windows 10 #236

Closed
zaucy opened this issue Mar 17, 2019 · 4 comments
Closed

File changes beyond the first are not detected on Windows 10 #236

zaucy opened this issue Mar 17, 2019 · 4 comments

Comments

@zaucy
Copy link
Contributor

zaucy commented Mar 17, 2019

Tested on latest master (commit at time of writing = 01bdaa8). May affect other platforms, but I have only tested on Windows 10.

This change fixes my issue: zaucy@d8eb7cd

I didn't want to make a pull request because I am not that familiar with go or fsnotify to understand why this works. Can anyone chime in?

@zaucy zaucy changed the title File changes beyond the first is not detected on Windows 10 File changes beyond the first are not detected on Windows 10 Mar 17, 2019
@achew22
Copy link
Member

achew22 commented Mar 17, 2019

@zaucy, first off thanks for the issue report! It looks like there must be a bug in source_event_handler.go given the error conditions you describe

  • Does this consistently happen?
    • If so what percentage of the time?
  • Would you be willing to help debug things a little bit more by running a few commands and possibly compiling/running a binary to pull fsnotify events?
  • What version of Windows 10 are you running?

Thanks!

@zaucy
Copy link
Contributor Author

zaucy commented Mar 17, 2019

Does this consistently happen?

Yes 100% of the time

Would you be willing to help debug things a little bit more by running a few commands and possibly compiling/running a binary to pull fsnotify events?

Yep absolutely

What version of Windows 10 are you running?

Windows 10 Pro 10.0.17763 Build 17763

@github-actions
Copy link

Stale issue message

@zaucy
Copy link
Contributor Author

zaucy commented Dec 18, 2019

I don't know what/where anything has changed, but I haven't had this issue for awhile now so I'm going to close it.

@zaucy zaucy closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants