Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0] archive_override() and git_override() should allow for same arguments as their repository rule counterparts #24442

Closed
bazel-io opened this issue Nov 21, 2024 · 3 comments
Closed

[8.0.0] archive_override() and git_override() should allow for same arguments as their repository rule counterparts #24442

bazel-io opened this issue Nov 21, 2024 · 3 comments
Labels
soft-release-blocker Soft release blockers that are nice to have, but shouldn't block the release if it's the last one.
Milestone
8.0.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #24412
@bazel-io bazel-io added this to the 8.0.0 release blockers milestone Nov 21, 2024
@Wyverald Wyverald added the soft-release-blocker Soft release blockers that are nice to have, but shouldn't block the release if it's the last one. label Nov 21, 2024
@Wyverald
Copy link
Member

will probably need to cherry-pick a bunch of dependency CLs -- so don't block rc3 on this

@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ArchiveOverride.java
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/GitOverride.java
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/InterimModule.java
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/LocalPathOverride.java
src/main/java/com/google/devtools/build/lib/skyframe/BzlmodRepoRuleFunction.java

cc: @bazelbuild/triage

@Wyverald
Copy link
Member

#24443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
soft-release-blocker Soft release blockers that are nice to have, but shouldn't block the release if it's the last one.
Projects
None yet
Milestone
8.0.0 release blockers
Development

No branches or pull requests
3 participants
@Wyverald @bazel-io @iancha1992